New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENV/std: fully extend from HOMEBREW_PATH. #3387

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
1 participant
@MikeMcQuaid
Member

MikeMcQuaid commented Oct 28, 2017

Rather than just re-adding HOMEBREW_PREFIX/bin if it's missing re-add everything from HOMEBREW_PATH. This works well with or without environment filtering being enabled but with environment filtering it ensures that ENV/std just builds on the original user environment.

ENV/std: fully extend from HOMEBREW_PATH.
Rather than just re-adding HOMEBREW_PREFIX/bin if it's missing re-add
everything from HOMEBREW_PATH. This works well with or without
environment filtering being enabled but with environment filtering it
ensures that ENV/std just builds on the original user environment.
# @private
def setup_build_environment(formula = nil)
super
PATH.new(ENV["HOMEBREW_PATH"]).each { |p| prepend_path "PATH", p }

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Oct 30, 2017

Member

@reitermarkus Does this seem the best way to do this?

@MikeMcQuaid

MikeMcQuaid Oct 30, 2017

Member

@reitermarkus Does this seem the best way to do this?

@MikeMcQuaid MikeMcQuaid merged commit 2d5bb02 into Homebrew:master Oct 30, 2017

2 of 3 checks passed

codecov/patch 0% of diff hit (target 68.49%)
Details
codecov/project 68.56% (+0.07%) compared to 9dbff4e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:env-std-homebrew-paths branch Oct 30, 2017

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.