.simplecov: filter more filters/folders. #3545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is stuff that can never be exercised by our test suite but is exercised by `brew test-bot` so remove it from the coverage checks.
reitermarkus
reviewed
Dec 8, 2017
| add_filter %r{^/os/mac/} unless RbConfig::CONFIG["host_os"].include?("darwin") | ||
| unless RbConfig::CONFIG["host_os"].include?("linux") | ||
| add_filter %r{^/os/linux/} | ||
| end |
There was a problem hiding this comment.
Why the two different styles here?
There was a problem hiding this comment.
rubocop changing this based on the line length.
reitermarkus
reviewed
Dec 8, 2017
| @@ -38,11 +38,22 @@ SimpleCov.start do | |||
| track_files "#{SimpleCov.root}/{#{subdirs},*.rb}" | |||
| end | |||
|
|
|||
| add_filter %r{^/build.rb$} | |||
| add_filter %r{^/config.rb$} | |||
| add_filter %r{^/constants.rb$} | |||
There was a problem hiding this comment.
Shouldn‘t this be covered by running any integration test?
There was a problem hiding this comment.
Or it's been already included.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stuff that can never be exercised by our test suite but is exercised by
brew test-botso remove it from the coverage checks.