Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let cask doctor exit with 1 #3631

Merged
merged 3 commits into from
Feb 12, 2018
Merged

Let cask doctor exit with 1 #3631

merged 3 commits into from
Feb 12, 2018

Conversation

amyspark
Copy link
Contributor

@amyspark amyspark commented Jan 5, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

(I am reopening #3418 with this pull request, since it got stale)

This pull request fixes Homebrew/homebrew-cask#40198 by raising a CaskError if one or more of the checks fails.

Please review!

@amyspark
Let Cask doctor exit with 1 via a CaskError
84e4119
@amyspark
Refactor Cask's doctor command
691caf4 
- Remove :failed
- Use Checkable to store the status and warnings/errors
- Refactor the methods using audit as basis
@MikeMcQuaid MikeMcQuaid added the in progress Maintainers are working on this label Jan 6, 2018
@amyspark
Copy link
Contributor Author

/ping @reitermarkus

reitermarkus
reitermarkus previously requested changes Jan 28, 2018
View reviewed changes
Copy link
Member

@reitermarkus reitermarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small changes, otherwise 👍.

Library/Homebrew/cask/lib/hbc/cli/doctor.rb Outdated
check_environment_variables

puts summary unless success?
raise CaskError, "Your system is not ready for Cask." unless success?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe “There are some problems with your setup.”.

Library/Homebrew/cask/lib/hbc/cli/doctor.rb Outdated
end

def summary_header
"Cask's Doctor checkup"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize “checkup”.

@amyspark
Copy link
Contributor Author

amyspark commented Feb 6, 2018

@reitermarkus, can you check if this is all right?

@MikeMcQuaid MikeMcQuaid merged commit 918f1b7 into Homebrew:master Feb 12, 2018
@MikeMcQuaid
Copy link
Member

Thanks @amyspark!

@commitay commitay mentioned this pull request Feb 13, 2018
Merged
6 tasks
@reitermarkus
Copy link
Member

Thanks, @amyspark! I was about to get back to this today, but looks like Mike beat me by a day. 😉

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@reitermarkus reitermarkus reitermarkus left review comments

Assignees
No one assigned
Labels
in progress Maintainers are working on this
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug report: brew cask doctor should have return code != 0 in case of error
3 participants
@amyspark @MikeMcQuaid @reitermarkus