New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fix depends_on examples in Formula page #3668

Merged

MikeMcQuaid merged 2 commits into Homebrew:master from shigemk2:rubydoc-depends_on

Jan 11, 2018

Contributor

shigemk2 commented Jan 11, 2018 •

edited

Loading

example:

Error: depends_on :mysql
Correct: depends_on "mysql"

refer: #3612

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew tests with your changes locally?

shigemk2 and others added 2 commits

January 11, 2018 21:05


          docs: Fix depends_on examples in Formula page

f5e8b26

example:

Error: depends_on :mysql
Correct: depends_on "mysql"


          formula: tweak more depends_on examples.

e903a5f

MikeMcQuaid approved these changes

View reviewed changes

Member

MikeMcQuaid commented Jan 11, 2018

Thanks for your first contribution to Homebrew, @shigemk2 ! Without people like you submitting PRs we couldn't run this project. You rock!

MikeMcQuaid merged commit f0567d5 into Homebrew:master

Homebrew locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.