Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doctor and style to checklist. #3722

Merged
merged 2 commits into from Jan 23, 2018
Merged

Add doctor and style to checklist. #3722

merged 2 commits into from Jan 23, 2018

Conversation

sesam
Copy link
Contributor

@sesam sesam commented Jan 23, 2018

Ensures that contributors know about brew doctor and brew style before submitting a PR, since CI fails on brew style breaches.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

@sesam
Add doctor and style to checklist.
480a25a 
Ensures that contributors know about `brew doctor` and `brew style` before submitting a PR, since CI fails on `brew style` breaches.
ilovezfs
ilovezfs reviewed Jan 23, 2018
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Outdated
@@ -2,6 +2,8 @@
- [ ] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?
- [ ] Have you added an explanation of what your changes do and why you'd like us to include them?
- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).
- [ ] Have you successfully run `brew style` with your changes locally?
- [ ] Have you successfully run `brew doctor` with your changes locally?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are too many benign things flagged by doctor so let's not add that bullet

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, removing that row again. While CI seems to fail if brew doctor fails, it's maybe unusual for doctor to fail due to new changes.

@MikeMcQuaid
Copy link
Member

I don't think this is necessary as CI will provide this information.

@MikeMcQuaid
Copy link
Member

To elaborate more: these were necessary for your PR because you were modifying doctor's code. I don't think people not following brew style is occurring often enough to justify the addition to this list (but others may disagree).

@MikeMcQuaid
Copy link
Member

Actually, sure, let's add brew style as we tell people to run brew tests.
Thanks so much for your contribution! Without people like you submitting PRs we couldn't run this project. You rock, @sesam!

@MikeMcQuaid MikeMcQuaid merged commit e056e85 into Homebrew:master Jan 23, 2018
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilovezfs ilovezfs ilovezfs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sesam @MikeMcQuaid @ilovezfs