Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: call satisified? before modifying env. #3724

Merged
merged 5 commits into from
Jan 23, 2018

Conversation

ilovezfs
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew tests with your changes locally?

Requirement#modify_build_environment may depend on the side effects of
Requirement#satisfied?, so make sure the latter is called at least once
for each requirement during formula installation. Prior to b70b542,
Requirement#satisfied? would usually be called during Build#expand_reqs,
but that is longer the case.

Requirement#modify_build_environment may depend on the side effects of
Requirement#satisfied?, so make sure the latter is called at least once
for each requirement during formula installation. Prior to b70b542,
Requirement#satisfied? would usually be called during Build#expand_reqs,
but that is longer the case.
@ilovezfs
Copy link
Contributor Author

Right now, JAVA_HOME is no longer getting set during def install, which leads to failures like https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/16982/version=high_sierra/console

@MikeMcQuaid MikeMcQuaid merged commit ea0af7d into Homebrew:master Jan 23, 2018
dunn added a commit to brew-stuff/homebrew-emacs that referenced this pull request Jan 25, 2018
dunn added a commit to brew-stuff/homebrew-emacs that referenced this pull request Jan 29, 2018
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants