xcode_requirement: inform users of macOS upgrade. #3749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you need a newer Xcode than the latest version provided by your version of macOS then you need to upgrade your OS to install the software.
ilovezfs
reviewed
Jan 29, 2018
| @@ -22,7 +22,12 @@ def message | |||
| A full installation of Xcode.app#{version} is required to compile this software. | |||
| Installing just the Command Line Tools is not sufficient. | |||
| EOS | |||
| if MacOS.version >= :lion | |||
| if Version.new(MacOS::Xcode.latest_version) < Version.new(@version) | |||
There was a problem hiding this comment.
Why is MacOS::Xcode.latest_version not already a Version object?
ilovezfs
approved these changes
Jan 29, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you need a newer Xcode than the latest version provided by your version of macOS then you need to upgrade your OS to install the software.