New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcode_requirement: inform users of macOS upgrade. #3749

Merged
merged 1 commit into from Jan 29, 2018

Conversation

Projects
None yet
2 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Jan 29, 2018

If you need a newer Xcode than the latest version provided by your version of macOS then you need to upgrade your OS to install the software.

xcode_requirement: inform users of macOS upgrade.
If you need a newer Xcode than the latest version provided by your
version of macOS then you need to upgrade your OS to install the
software.
@@ -22,7 +22,12 @@ def message
A full installation of Xcode.app#{version} is required to compile this software.
Installing just the Command Line Tools is not sufficient.
EOS
if MacOS.version >= :lion
if Version.new(MacOS::Xcode.latest_version) < Version.new(@version)

This comment has been minimized.

@ilovezfs

ilovezfs Jan 29, 2018

Contributor

Why is MacOS::Xcode.latest_version not already a Version object?

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Jan 29, 2018

Member

We Shall Never Know

@MikeMcQuaid MikeMcQuaid merged commit 28ce1a1 into Homebrew:master Jan 29, 2018

1 of 3 checks passed

codecov/patch 0% of diff hit (target 70.35%)
Details
codecov/project 70.34% (-0.01%) compared to 91f9802
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:xcode-requirement-macos-upgrade branch Jan 29, 2018

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.