Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostic: guard cache check on Jenkins too #3791

Merged
merged 1 commit into from Feb 12, 2018
Merged

diagnostic: guard cache check on Jenkins too #3791

merged 1 commit into from Feb 12, 2018

Conversation

DomT4
Copy link
Member

@DomT4 DomT4 commented Feb 12, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Apparently Jenkins doesn't set CI in the env automatically? This should get CI working again. Sorry!

@MikeMcQuaid MikeMcQuaid merged commit e904983 into Homebrew:master Feb 12, 2018
@MikeMcQuaid
Copy link
Member

@DomT4 Thanks for the quick fix. Merging for now but I want to tweak this so we don't have to keep remembering to set JENKINS_HOME here.

@DomT4
Copy link
Member Author

DomT4 commented Feb 12, 2018

Maybe Utils.is_a_robot? or something that combines these variables into a blob, since we're using it more than once now.

@DomT4
Copy link
Member Author

DomT4 commented Feb 12, 2018

Thanks for merging. Apologies for this one; was sure Jenkins set CI by default sigh. Maybe I was misremembering and thinking of Travis, which is possible.

@DomT4 DomT4 deleted the cache_ci branch February 12, 2018 10:21
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants