Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-cmd/ruby: fix path to dev-cmd/irb and add test #3853

Merged
merged 1 commit into from
Feb 28, 2018

Conversation

scpeters
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The brew ruby command was broken by #3851 (cannot load such file -- cmd/irb (LoadError)):

$ brew ruby -e 'exit 0'
/usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require': cannot load such file -- cmd/irb (LoadError)
	from /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby/2.3.3/lib/ruby/2.3.0/rubygems/core_ext/kernel_require.rb:55:in `require'

The irb command was moved to dev-cmd but we forgot to update the path embedded in the ruby command. This fixes the path and adds a very basic test for the ruby command.

@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Feb 28, 2018

Oops, thanks for the fix!

@MikeMcQuaid MikeMcQuaid merged commit 9225dac into Homebrew:master Feb 28, 2018
@scpeters scpeters deleted the fix_brew_ruby branch February 28, 2018 18:18
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants