Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keg: delete_pyc_files! should also remove __pycache__ #3892

Merged
merged 3 commits into from Mar 8, 2018

Conversation

lembacon
Copy link
Member

@lembacon lembacon commented Mar 8, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

As Python 3 becomes the default Python in the core tap, bottles built against Python 3 become a thing. Both .pycand .pyo have already been removed from bottles, we should also remove __pycache__. Otherwise people who have PYTHONDONTWRITEBYTECODE set will find this really annoying.

@MikeMcQuaid MikeMcQuaid merged commit 1d708d7 into Homebrew:master Mar 8, 2018
@MikeMcQuaid
Copy link
Member

Thanks again @lembacon!

@MikeMcQuaid
Copy link
Member

Oh, this was your first Homebrew/brew PR! In that case:
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @lembacon 😁

@MikeMcQuaid
Copy link
Member

FYI I reverted my two tweak commits because __pycache__ is a directory containing those cache files so can only be removed after they are.

@lembacon lembacon deleted the pycache branch March 8, 2018 14:46
@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants