Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up compat. #4186

Merged
merged 2 commits into from May 18, 2018
Merged

Clean up compat. #4186

merged 2 commits into from May 18, 2018

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented May 17, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Always use this style:

module Compat
end

prepend Compat

@ghost ghost assigned reitermarkus May 17, 2018
@ghost ghost added the in progress Maintainers are working on this label May 17, 2018
@MikeMcQuaid
Copy link
Member

There's still e.g. compat/formula.rb using the "open the existing class to overwrite the method" style; you might want to read through all the files in compat for comparison. This style is also taken by extend/os too if it made sense to clean that up in the same fashion.

@reitermarkus
Copy link
Member Author

Well, prepend is only needed if the compatibility layer should be able to call the current implementation, i.e. super, but I guess we can use the same style anyways, just to be consistent.

@MikeMcQuaid
Copy link
Member

Well, prepend is only needed if the compatibility layer should be able to call the current implementation, i.e. super, but I guess we can use the same style anyways, just to be consistent.

👍 Gotcha. I'm fine either way. For a future PR this does apply a bunch to the extend/os layer so doing it there too would be 🎉

@reitermarkus reitermarkus merged commit 54270e9 into Homebrew:master May 18, 2018
@reitermarkus reitermarkus deleted the compat branch May 18, 2018 16:52
@ghost ghost removed the in progress Maintainers are working on this label May 18, 2018
@lock lock bot added the outdated PR was locked due to age label Jun 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants