Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror: use curl_executable instead of curl function #4375

Merged
merged 1 commit into from Jun 25, 2018

Conversation

ilovezfs
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

More testing shows that the curl function results in

$ brew mirror lzip
curl: (22) The requested URL returned error: 404 Not Found
Error: Failure while executing: /usr/local/opt/curl/bin/curl -q --show-error --user-agent Homebrew/1.6.9-25-g535f1fb\ (Macintosh;\ Intel\ Mac\ OS\ X\ 10.8.5)\ curl/7.60.0 --fail --progress-bar --silent --fail --output /dev/null https://api.bintray.com/packages/homebrew/mirror/lzip

in the case where the formula has never been mirrored to Bintray before.

@ghost ghost assigned ilovezfs Jun 25, 2018
@ghost ghost added the in progress Maintainers are working on this label Jun 25, 2018
@ilovezfs ilovezfs merged commit 7db0f97 into Homebrew:master Jun 25, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jun 25, 2018
@lock lock bot added the outdated PR was locked due to age label Jul 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant