Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby.sh: cleanup gems on portable Ruby installation. #4467

Merged
merged 1 commit into from
Jul 13, 2018
Merged

ruby.sh: cleanup gems on portable Ruby installation. #4467

merged 1 commit into from
Jul 13, 2018

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented Jul 13, 2018 •
edited
Loading

This avoids brew style and friends from getting upset when they attempt to use the native gem extensions from a previous portable Ruby or a system Ruby.

ABI? What's that?

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid
ruby.sh: cleanup gems on portable Ruby installation.
9b86ff6 
This avoids `brew style` and friends from getting upset when they
attempt to use the native gem extensions from a previous portable Ruby
or a system Ruby.

ABI? What's that?
@ghost ghost assigned MikeMcQuaid Jul 13, 2018
@ghost ghost added the in progress Maintainers are working on this label Jul 13, 2018
@MikeMcQuaid MikeMcQuaid merged commit 5c2aaef into Homebrew:master Jul 13, 2018
@ghost ghost removed the in progress Maintainers are working on this label Jul 13, 2018
@MikeMcQuaid MikeMcQuaid deleted the portable-ruby-cleanup-gems branch July 13, 2018 13:55
@lock lock bot added the outdated PR was locked due to age label Aug 12, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilovezfs ilovezfs ilovezfs approved these changes

Assignees

@MikeMcQuaid MikeMcQuaid

Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MikeMcQuaid @ilovezfs