New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `String#delete_prefix` backport. #4906

Merged
merged 1 commit into from Sep 16, 2018

Conversation

Projects
None yet
2 participants
@reitermarkus
Copy link
Member

reitermarkus commented Sep 14, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@reitermarkus reitermarkus requested a review from MikeMcQuaid Sep 14, 2018

@wafflebot wafflebot bot added the in progress label Sep 14, 2018

@reitermarkus reitermarkus force-pushed the reitermarkus:backports-delete-prefix branch from 12d11d1 to 3a0a9f9 Sep 16, 2018

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Sep 16, 2018

Nice work 👍

@reitermarkus reitermarkus merged commit 2e2e8cc into Homebrew:master Sep 16, 2018

2 of 3 checks passed

codecov/patch 60% of diff hit (target 71.18%)
Details
codecov/project 71.18% (-<.01%) compared to dfb6ada
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Sep 16, 2018

@reitermarkus reitermarkus deleted the reitermarkus:backports-delete-prefix branch Sep 16, 2018

@lock lock bot added the outdated label Oct 16, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Oct 16, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.