Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: check versioned formulae for keg_only :versioned_formula #5091

Merged
merged 1 commit into from Oct 20, 2018
Merged

audit: check versioned formulae for keg_only :versioned_formula #5091

merged 1 commit into from Oct 20, 2018

Conversation

commitay
Copy link
Contributor

@commitay commitay commented Oct 12, 2018

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is intended to enforce the (almost) default expectation that versioned @ formulae should be keg_only :versioned_formula.

Whitelisted:

  • autoconf@2.13: suffixed
  • bash-completion@2: conflicts with bash-completion, also whitelisted in conflicts cop
  • gcc@* formulae: suffixed
  • gnupg@1.4: suffixed
  • lua@5.1: doesn't conflict with lua
  • python@2: doesn't conflict with python

Stuff that should probably be fixed in core:

@MikeMcQuaid
Copy link
Member

Nice work @commitay!

@commitay commitay merged commit 5989095 into Homebrew:master Oct 20, 2018
@commitay commitay deleted the versioned-keg-only branch October 20, 2018 03:40
@lock lock bot added the outdated PR was locked due to age label Nov 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants