New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused download strategies #5112

Merged
merged 1 commit into from Oct 19, 2018

Conversation

Projects
None yet
3 participants
@MikeMcQuaid
Copy link
Member

MikeMcQuaid commented Oct 15, 2018

Download the unused, private download strategies. These are a better fit for being declared in the formulae and/or taps that use them rather than in Homebrew/brew where they are unused by Homebrew maintainers or official taps/formulae.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?


# Download via an HTTP POST.
# Query parameters on the URL are converted into POST parameters
class CurlPostDownloadStrategy < CurlDownloadStrategy

This comment has been minimized.

@commitay

commitay Oct 15, 2018

Contributor

Cask uses POST.

This comment has been minimized.

@MikeMcQuaid

MikeMcQuaid Oct 15, 2018

Member

@commitay Which casks? I looked and couldn't find them.

This comment has been minimized.

@commitay

commitay Oct 15, 2018

Contributor

Two, both in drivers.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:deprecate-download-strategies branch from fea0897 to 50a5369 Oct 15, 2018

@commitay

This comment has been minimized.

Copy link
Contributor

commitay commented Oct 17, 2018

Might be worthwhile setting a disable_on: date so people have a deadline to implement their own download strategies?

@MikeMcQuaid

This comment has been minimized.

Copy link
Member

MikeMcQuaid commented Oct 17, 2018

@commitay Generally I avoid them in favour for formulae stuff in favour of using minor releases for them (i.e I wouldn't remove until 1.9). Thoughts?

@colindean

This comment has been minimized.

Copy link
Member

colindean commented Oct 18, 2018

Do Homebrew metrics happen to have data on how widely these are used inside the firewall by private taps?

@commitay

This comment has been minimized.

Copy link
Contributor

commitay commented Oct 18, 2018

I think "deprecated + will be disabled on" is a stronger/clearer message than just "deprecated" by itself.

That said, I'm sure we'll still get some complaints no matter what we do. 😆

Deprecate unused download strategies
Download the unused, private download strategies. These are a better fit
for being declared in the formulae and/or taps that use them rather than
in Homebrew/brew where they are unused by Homebrew maintainers or
official taps/formulae.

@MikeMcQuaid MikeMcQuaid force-pushed the MikeMcQuaid:deprecate-download-strategies branch from 50a5369 to 599ecc9 Oct 19, 2018

@MikeMcQuaid MikeMcQuaid merged commit 4a0e97d into Homebrew:master Oct 19, 2018

3 checks passed

codecov/patch 100% of diff hit (target 70.78%)
Details
codecov/project 70.8% (+0.02%) compared to 1f08739
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MikeMcQuaid MikeMcQuaid deleted the MikeMcQuaid:deprecate-download-strategies branch Oct 19, 2018

@lock lock bot added the outdated label Nov 18, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Nov 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.