Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate unused download strategies #5112

Merged
merged 1 commit into from
Oct 19, 2018
Merged

Deprecate unused download strategies #5112

merged 1 commit into from
Oct 19, 2018

Conversation

MikeMcQuaid
Copy link
Member

Download the unused, private download strategies. These are a better fit for being declared in the formulae and/or taps that use them rather than in Homebrew/brew where they are unused by Homebrew maintainers or official taps/formulae.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

commitay
commitay reviewed Oct 15, 2018
View reviewed changes
Library/Homebrew/compat/download_strategy.rb Outdated

# Download via an HTTP POST.
# Query parameters on the URL are converted into POST parameters
class CurlPostDownloadStrategy < CurlDownloadStrategy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cask uses POST.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@commitay Which casks? I looked and couldn't find them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two, both in drivers.

@commitay
Copy link
Contributor

Might be worthwhile setting a disable_on: date so people have a deadline to implement their own download strategies?

@MikeMcQuaid
Copy link
Member Author

@commitay Generally I avoid them in favour for formulae stuff in favour of using minor releases for them (i.e I wouldn't remove until 1.9). Thoughts?

@colindean
Copy link
Sponsor Member

colindean commented Oct 18, 2018 •
edited
Loading

Do Homebrew metrics happen to have data on how widely these are used inside the firewall by private taps?

@commitay
Copy link
Contributor

I think "deprecated + will be disabled on" is a stronger/clearer message than just "deprecated" by itself.

That said, I'm sure we'll still get some complaints no matter what we do. 😆

@MikeMcQuaid
Deprecate unused download strategies
599ecc9 
Download the unused, private download strategies. These are a better fit
for being declared in the formulae and/or taps that use them rather than
in Homebrew/brew where they are unused by Homebrew maintainers or
official taps/formulae.
@MikeMcQuaid MikeMcQuaid merged commit 4a0e97d into Homebrew:master Oct 19, 2018
@MikeMcQuaid MikeMcQuaid deleted the deprecate-download-strategies branch October 19, 2018 15:07
@lock lock bot added the outdated PR was locked due to age label Nov 18, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@commitay commitay commitay approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @commitay @colindean