Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing method to_a to Cask::DSL:ConflictsWith class. #5597

Merged

Conversation

cmbernard333
Copy link
Contributor

@cmbernard333 cmbernard333 commented Jan 23, 2019

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#5596

…ed ConflictsWith#to_h to iterate over VALID_KEYS.
@reitermarkus reitermarkus merged commit d0202f6 into Homebrew:master Jan 27, 2019
@reitermarkus
Copy link
Member

Thanks, @cmbernard333!

@lock lock bot added the outdated PR was locked due to age label Feb 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants