-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs/Shell-Completion: read both types of bash completions. #5625
Conversation
And guard against either of them being missing. Fixes #5610
Hey for whatever reason the first
Doing:
and also tried on Linux with bash version 4.2.+. |
@ikatza What does |
|
@ikatza You'll need to figure this out yourself, then, that all looks like it should work. |
Well that's kinda of what I did. I've been googling for the
|
|
Oh! There is a typo in instructions! |
@@ -12,13 +12,19 @@ To make Homebrew's completions available in `bash`, you must source the definiti | |||
|
|||
```sh | |||
if type brew 2&>/dev/null; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the typo
Fixes the issue noted in #5625.
I get masses of errors when using this snippet in my bashrc
Full output here: https://gist.github.com/raldred/098801f9ea47bd37c64652af2ef35baf |
This means you have |
And guard against either of them being missing.
Fixes #5610
brew style
with your changes locally?brew tests
with your changes locally?