Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: don't remove portable ruby on periodic cleanups. #5722

Merged
merged 1 commit into from Feb 13, 2019

Conversation

MikeMcQuaid
Copy link
Member

Otherwise we end up deleting the running Ruby version.

Fixes #5707.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Otherwise we end up deleting the running Ruby version.

Fixes #5707.
@MikeMcQuaid MikeMcQuaid merged commit 14a503f into Homebrew:master Feb 13, 2019
@MikeMcQuaid MikeMcQuaid deleted the periodic-cleanup-ruby branch February 13, 2019 14:40
@Amit-PivotalLabs
Copy link

Thanks @MikeMcQuaid. Do you have any suggestions for anyone who used brew before this fix and lost portable ruby?

@MikeMcQuaid
Copy link
Member Author

@Amit-PivotalLabs Why do you need portable Ruby?

@lock lock bot added the outdated PR was locked due to age label Mar 20, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants