Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up blacklisted package messages #5759

Merged
merged 3 commits into from
Feb 19, 2019
Merged

Clean up blacklisted package messages #5759

merged 3 commits into from
Feb 19, 2019

Conversation

adunning
Copy link
Contributor

Ensure consistent formatting and provide references to all MacTeX packages.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@adunning
Clean up blacklisted package messages
60b698b 
Ensure consistent formatting and provide references to all MacTeX packages
MikeMcQuaid
MikeMcQuaid reviewed Feb 17, 2019
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Some suggestions.

Library/Homebrew/missing_formula.rb Outdated Show resolved Hide resolved
Library/Homebrew/missing_formula.rb Outdated Show resolved Hide resolved
Library/Homebrew/missing_formula.rb Outdated Show resolved Hide resolved
Library/Homebrew/missing_formula.rb Outdated Show resolved Hide resolved
@adunning
Copy link
Contributor Author

Thanks to both @MikeMcQuaid and @chdiza for your comments! I have implemented your suggestions.

@MikeMcQuaid
Copy link
Member

Beautiful!
Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock @adunning!

@MikeMcQuaid MikeMcQuaid merged commit 78a1732 into Homebrew:master Feb 19, 2019
@adunning adunning deleted the patch-1 branch February 19, 2019 15:39
@adunning
Copy link
Contributor Author

Thank you!

@lock lock bot added the outdated PR was locked due to age label Mar 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid left review comments

@vitorgalvao vitorgalvao vitorgalvao left review comments

@chdiza chdiza chdiza left review comments

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adunning @MikeMcQuaid @vitorgalvao @chdiza