Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Bundler cleanup #5814

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

MikeMcQuaid
Copy link
Member

Rather than trying to be smart and doing this ourselves in brew cleanup let’s just installed Bundler somewhere it doesn’t try to clean itself up and use bundle install --cleanup when we need cleanup done.

Also, use ohai and odie when possible as they look nicer.

Fixes #5798

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid MikeMcQuaid force-pushed the improve-bundler-cleanup branch 3 times, most recently from 6ced897 to eb2f360 Compare February 26, 2019 22:13
Rather than trying to be smart and doing this ourselves in `brew cleanup` let’s just installed Bundler somewhere it doesn’t try to clean itself up and use `bundle install --cleanup` when we need cleanup done.

Also, use `ohai` and `odie` when possible as they look nicer.
@MikeMcQuaid MikeMcQuaid merged commit 95660b8 into Homebrew:master Feb 27, 2019
@MikeMcQuaid MikeMcQuaid deleted the improve-bundler-cleanup branch February 27, 2019 14:37
@lock lock bot added the outdated PR was locked due to age label Mar 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant