Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #unstable? method for cask versions. #5893

Merged
merged 1 commit into from
Apr 14, 2019
Merged

Add #unstable? method for cask versions. #5893

merged 1 commit into from
Apr 14, 2019

Conversation

reitermarkus
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

To be used in automerge. Also, remove tests for slashes_to_* and no_slashes, since slashes shouldn't be used in versions.

@reitermarkus reitermarkus requested a review from a team March 19, 2019 04:05
MikeMcQuaid
MikeMcQuaid approved these changes Mar 19, 2019
View reviewed changes
Library/Homebrew/cask/dsl/version.rb Outdated Show resolved Hide resolved
@reitermarkus reitermarkus mentioned this pull request Mar 21, 2019
Closed
6 tasks
@vitorgalvao vitorgalvao mentioned this pull request Mar 26, 2019
Merged
@reitermarkus reitermarkus marked this pull request as ready for review March 27, 2019 12:48
amyspark
amyspark approved these changes Apr 13, 2019
View reviewed changes
Copy link
Contributor

@amyspark amyspark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the delay!

@MikeMcQuaid MikeMcQuaid merged commit 0750971 into Homebrew:master Apr 14, 2019
@MikeMcQuaid
Copy link
Member

Cheers @reitermarkus!

@vitorgalvao vitorgalvao mentioned this pull request Apr 17, 2019
Merged
6 tasks
@lock lock bot added the outdated PR was locked due to age label May 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2019
@reitermarkus reitermarkus deleted the version-unstable branch August 19, 2019 16:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@amyspark amyspark amyspark approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reitermarkus @MikeMcQuaid @amyspark