Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a flurry of improvements to the brew fish completions #6430

Merged

Conversation

lwolfsonkin
Copy link
Contributor

@lwolfsonkin lwolfsonkin commented Sep 7, 2019

  • Add --language option to brew install and brew audit completion
  • Add brew cask upgrade --dry-run completion
  • Add cask completions to brew cleanup
  • Drop completions for now-deleted brew prune command

Also, fixed documentation on website to reflect that brew ships fish completions now.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@MikeMcQuaid MikeMcQuaid merged commit 3f62a5a into Homebrew:master Sep 9, 2019
@MikeMcQuaid
Copy link
Member

Thanks again @ynppny!

@lwolfsonkin lwolfsonkin deleted the brew-fish-completions-update branch September 10, 2019 17:12
@lock lock bot added the outdated PR was locked due to age label Jan 1, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants