Fix #6533 - Add support for zsh ZDOTDIR #6540

davidosomething · 2019-10-06T16:47:44Z

Have you followed the guidelines in our Contributing document?
Have you checked to ensure there aren't other open Pull Requests for the same change?
Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your changes? Here's an example.
Have you successfully run brew style with your changes locally?
Have you successfully run brew tests with your changes locally?

See #6533 for context

Added one test spec where I set the ZDOTDIR env var
I'm not a ruby developer so please review prudently!

- Add test spec with ZDOTDIR set and unset

Library/Homebrew/utils/shell.rb

Library/Homebrew/test/utils/shell_spec.rb

MikeMcQuaid · 2019-10-07T13:32:34Z

Thanks for the PR @davidosomething! A few suggestions (which may fix the tests but if not I'll make more).

Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>

MikeMcQuaid · 2019-10-08T11:38:37Z

Thanks so much for your first contribution! Without people like you submitting PRs we couldn't run this project. You rock, @davidosomething!

Support for zsh ZDOTDIR, FIX Homebrew#6533

960b8b6

- Add test spec with ZDOTDIR set and unset

MikeMcQuaid reviewed Oct 7, 2019

View reviewed changes

Library/Homebrew/utils/shell.rb Outdated Show resolved Hide resolved

Library/Homebrew/test/utils/shell_spec.rb Show resolved Hide resolved

davidosomething and others added 2 commits October 7, 2019 10:25

Update Library/Homebrew/utils/shell.rb

5ca4b43

Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>

utils/shell: match preferred shell by symbol.

36bc11b

MikeMcQuaid merged commit 59e3cc7 into Homebrew:master Oct 8, 2019

lock bot added the outdated PR was locked due to age label Jan 1, 2020

lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020

Provide feedback