Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARGV: Replace ARGV.verbose? with Homebrew.args.verbose? #6983

Merged
merged 1 commit into from Feb 2, 2020

Conversation

GauthamGoli
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

#5730

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Can ARGV.verbose? be deleted yet?

Library/Homebrew/cli/parser.rb Show resolved Hide resolved
@@ -127,7 +127,7 @@ def exec(*args)
end
end

if @failed && ARGV.verbose?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcQuaid Sandbox.exec runs in a separate thread, replacing this with Homebrew.args.verbose? does not work as CLI::Parser is not instantiated yet - so global args dependent on environment vars will not be set.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could fix this either by

  1. Directly checking if HOMEBREW_VERBOSE is set instead of Homebrew.args.verbose?
  2. Decoupling global args from CLI::Parser instantiation.
  3. Any other approach??

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Directly checking if HOMEBREW_VERBOSE is set instead of Homebrew.args.verbose?

This seems reasonable for a one-time thing 👍

@GauthamGoli
Copy link
Contributor Author

nice! Can ARGV.verbose? be deleted yet?

brew-test-bot extensively uses ARGV, so cannot deprecate ARGV.verbose? yet.

@MikeMcQuaid MikeMcQuaid merged commit bbe300a into Homebrew:master Feb 2, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @GauthamGoli !

@lock lock bot added the outdated PR was locked due to age label Mar 10, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants