Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump-formula-pr: Only delete Linux bottle line if it exists #7035

Conversation

@issyl0
Copy link
Member

issyl0 commented Feb 14, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

  • We have some Linux-only formulae that don't have bottles.
  • Previously, bumping a Linux-only formula that didn't have a bottle
    line - eg, adoptopenjdk which is bottle :unneeded - would fail:
Error: inreplace failed
/app/linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/adoptopenjdk.rb:

expected replacement of /^    sha256 ".+" => :x86_64_linux\n/m with "\2"

Fixes Homebrew/linuxbrew-core#19633

- We have some Linux-only formulae that don't have bottles.
- Previously, bumping a Linux-only formula that didn't have a bottle
  line - eg, `adoptopenjdk` which is `bottle :unneeded` - would fail:

```
Error: inreplace failed
/app/linuxbrew/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/adoptopenjdk.rb:

expected replacement of /^    sha256 ".+" => :x86_64_linux\n/m with "\2"
```
@issyl0 issyl0 requested a review from dawidd6 Feb 14, 2020
@dawidd6 dawidd6 merged commit 11bdacf into Homebrew:master Feb 14, 2020
3 checks passed
3 checks passed
tests (ubuntu-latest)
Details
tests (macOS-latest)
Details
coverage/coveralls First build on bump-formula-pr-fix-unbottled-linux-only-formulae at 73.463%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.