Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?Currently, line 264 does not work for one of the given examples
unrtf_0.20.4-1
Looking closer,
\d\.\d+
should be\d+\.\d+
where another+
is added to indicate that there can be more than one digit\d
.(A similar change is made to line 353.)
And as for line 274
m = /-((?:\d)+-\d+)/.match(stem)
, some redundancy can be removed by replacing(?:\d)
with\d
. Usually, the syntax(?:)
is used either for (1) matching a group of characters without creating a capture such as(?:\d+\.)*
or (2) "or" expressions such as(?:p|rc|RC)
. However, since it's just\d
by itself, it can be simplified.