Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/mac/xcode: support Xcode 11.4 #7228

Merged
merged 1 commit into from Mar 29, 2020
Merged

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Mar 26, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fun fact: the 11.4 CLT contains the macOS 10.14 SDK despite 10.14 no longer being supported.

@Bo98
Copy link
Member Author

Bo98 commented Mar 26, 2020

Obviously, this'll need to wait for the CI nodes to be updated. There's several big PRs going on at the moment anyway filling up the queue.

@Bo98
Copy link
Member Author

Bo98 commented Mar 28, 2020

Nodes are updated now.

@Bo98 Bo98 changed the title os/mac/xcode: prepare for Xcode 11.4 os/mac/xcode: support Xcode 11.4 Mar 29, 2020
@MikeMcQuaid MikeMcQuaid merged commit 9e503b1 into Homebrew:master Mar 29, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @Bo98 (and for the updates 💖).

@Bo98 Bo98 deleted the xcode-11.4 branch March 29, 2020 18:16
@lock lock bot added the outdated PR was locked due to age label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants