Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brew.sh: obey HOMEBREW_COLOR #7242

Merged
merged 1 commit into from Mar 31, 2020
Merged

brew.sh: obey HOMEBREW_COLOR #7242

merged 1 commit into from Mar 31, 2020

Conversation

dawidd6
Copy link
Member

@dawidd6 dawidd6 commented Mar 30, 2020 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Currently commands written in Bash like brew update-reset do not respect HOMEBREW_COLOR environment variable, so output might differ aesthetically with other Ruby commands.
This PR aims to change this situation.

MikeMcQuaid
MikeMcQuaid approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks @dawidd6!

@MikeMcQuaid MikeMcQuaid merged commit d9f8ad3 into Homebrew:master Mar 31, 2020
@dawidd6 dawidd6 deleted the patch-1 branch March 31, 2020 08:05
@lock lock bot added the outdated PR was locked due to age label May 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dawidd6 @MikeMcQuaid