bottle: author bottle commit as BrewTestBot

[dawidd6]

As it is in test-bot:
https://github.com/Homebrew/homebrew-test-bot/blob/6b2a8182f9d515f80722fda1dadab43ef4334e01/lib/test_bot.rb#L348-L350

Don't know if it is the correct implementation here, but a move must be made, because currently bottle commits are authored by the committer, rather than @BrewTestBot as it should be:
Homebrew/homebrew-core@242aab6

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[dawidd6]

Maybe just set the --author option in git commit here:

brew/Library/Homebrew/dev-cmd/bottle.rb

Lines 564 to 566 in 1a53802

	safe_system "git", "commit", "--no-edit", "--verbose",
	"--message=#{short_name}: #{update_or_add} #{pkg_version} bottle.",
	"--", path

[MikeMcQuaid]

Maybe just set the --author option in git commit here:

Yeh, this needs to happen on the original commit and set the author rather than the committer (which is what this PR is doing).

[jonchang]

Yeah, this looks like a good change.

[MikeMcQuaid]

This isn't correct. See the Utils.set_git_name_email! which sets these values based on HOMEBREW_GIT_NAME which brew test-bot sets: https://github.com/Homebrew/homebrew-test-bot/blob/355af90a55c07e079009a7862c137d65ee8db75c/lib/test_bot.rb#L348-L350.

As-is this will now override these values and set the author to @BrewTestBot for all uses of brew bottle --commit e.g. non-official taps.

[MikeMcQuaid]

This seems like an Actions-specific bug.

[dawidd6]

But even if maintainer would run brew pr-pull locally on their machine, the author of the bottle commit will still not be @BrewTestBot.

[MikeMcQuaid]

HOMEBREW_GITHUB_NAME etc. should be set in brew pr-pull for when it calls brew bottle in that case. If the bottle commit is being created locally, though, I'm not sure why it's desirable to have it attributed to @BrewTestBot anyway?

[dawidd6]

Just to keep things as they are right now, I guess. If it's not required, then okay.

[MikeMcQuaid]

Sorry 😭

[jonchang]

We should probably set those variables in the homebrew/core pr-publish workflow if we haven't already. I think we have but I need to check that it works properly.

[MikeMcQuaid]

Are we pulling those commits or are we creating the bottle commits locally?

[dawidd6]

Creating locally.

[MikeMcQuaid]

To be that sounds a bit like we should be attributing them to the local user, yeh.