Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Homebrew::EnvConfig: unify environment variables. #7285

Merged
merged 4 commits into from Apr 7, 2020
Merged

Homebrew::EnvConfig: unify environment variables. #7285

merged 4 commits into from Apr 7, 2020

Conversation

MikeMcQuaid
Copy link
Member

Like cli/parser but for environment variables. This makes it easier to set, check, document and set defaults for environment variables in a single location that can be used for query and documentation generation.

TODO: write unit tests for Homebrew::EnvConfig if no-one objects to the approach.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Bo98
Bo98 reviewed Apr 5, 2020
View reviewed changes
Library/Homebrew/download_strategy.rb Outdated Show resolved Hide resolved
Library/Homebrew/env_config.rb Show resolved Hide resolved
Library/Homebrew/system_config.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils.rb Show resolved Hide resolved
Library/Homebrew/global.rb Show resolved Hide resolved
Library/Homebrew/sandbox.rb Show resolved Hide resolved
Library/Homebrew/env_config.rb Outdated Show resolved Hide resolved
MikeMcQuaid
MikeMcQuaid commented Apr 5, 2020
View reviewed changes
Copy link
Member Author

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @Bo98, nice catches!

Library/Homebrew/env_config.rb Show resolved Hide resolved
Library/Homebrew/global.rb Show resolved Hide resolved
Library/Homebrew/sandbox.rb Show resolved Hide resolved
Library/Homebrew/system_config.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils.rb Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid force-pushed the env_consolidation branch 2 times, most recently from f4bf3ab to 92d98d7 Compare April 6, 2020 08:44
@MikeMcQuaid MikeMcQuaid force-pushed the env_consolidation branch 3 times, most recently from 59f5808 to 31ed7ca Compare April 6, 2020 09:29
@MikeMcQuaid
Copy link
Member Author

@Bo98 Ready for re-review, if you're game! Still have some unit tests to write but otherwise think this is good to go.

Bo98
Bo98 approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeMcQuaid
env_config: unify environment variables.
fb00520 
cli/parser but for environment variables. This makes it easier to set,
check, document and set defaults for environment variables in a single
location that can be used for query and documentation generation.
@MikeMcQuaid MikeMcQuaid merged commit e12da94 into Homebrew:master Apr 7, 2020
@MikeMcQuaid MikeMcQuaid deleted the env_consolidation branch April 7, 2020 09:35
@MikeMcQuaid MikeMcQuaid mentioned this pull request Apr 7, 2020
Merged
@EricFromCanada EricFromCanada mentioned this pull request Apr 7, 2020
Merged
6 tasks
@lock lock bot added the outdated PR was locked due to age label May 21, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Bo98 Bo98 Bo98 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MikeMcQuaid @komapa @Bo98