Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system_command_spec: Make part of bash error regex optional #7287

Merged
merged 1 commit into from
Apr 5, 2020
Merged

system_command_spec: Make part of bash error regex optional #7287

merged 1 commit into from
Apr 5, 2020

Conversation

rwhogg
Copy link
Contributor

@rwhogg rwhogg commented Apr 5, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example. Not applicable
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

brew tests fails on my system without this. Bash has two very similar error messages that can come up when running the command specified by this test. Here's the relevant code from subst.c in a recent version of Bash:

  else if (check_null == 0)
    report_error (_("%s: parameter not set"), name);
  else
    report_error (_("%s: parameter null or not set"), name);

@MikeMcQuaid MikeMcQuaid merged commit 6f50801 into Homebrew:master Apr 5, 2020
@MikeMcQuaid
Copy link
Member

Good catch, thanks @rwhogg!

@rwhogg rwhogg deleted the system_command_spec-more-specific-error-message branch April 11, 2020 22:18
@lock lock bot added the outdated PR was locked due to age label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants