Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

env_config: standardize wording, fix some typos #7312

Merged
merged 2 commits into from Apr 9, 2020
Merged

env_config: standardize wording, fix some typos #7312

merged 2 commits into from Apr 9, 2020

Conversation

jonchang
Copy link
Contributor

@jonchang jonchang commented Apr 9, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Standardizes the wording of environment variables. In particular, say "Homebrew uses this..." for variables where this value is set by default and merely refers to e.g., a standard path, and say "Homebrew will foo the bar..." for variables that change Homebrew's default behavior somehow.

Also fix several typos and spacing problems with multiline continuations.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. I'm somewhat tempted to strip the Homebrew ... prefix considering you're reading the Homebrew manpage but I'll defer to you there.

@jonchang
Copy link
Contributor Author

jonchang commented Apr 9, 2020

  • updating wording to avoid constantly repeating "Homebrew"

@jonchang jonchang merged commit 740e024 into Homebrew:master Apr 9, 2020
@jonchang jonchang deleted the environment-working branch April 9, 2020 15:52
@jonchang
Copy link
Contributor Author

jonchang commented Apr 9, 2020

Thanks for the review, and the whole ENV cleanup!

@lock lock bot added the outdated PR was locked due to age label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants