Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop.yml: remove formula exclusions. #7378

Merged
merged 1 commit into from Apr 18, 2020

Conversation

MikeMcQuaid
Copy link
Member

These have now been fixed so are no longer needed.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@Bo98
Copy link
Member

Bo98 commented Apr 18, 2020

On the note of GitHub Actions borking again with that "fatal: reference is not a tree" error, switching to actions/checkout@v2 might fix that. The way it fetches changed in v2.

These have now been fixed so are no longer needed.
@MikeMcQuaid MikeMcQuaid merged commit b2f90b2 into Homebrew:master Apr 18, 2020
@MikeMcQuaid MikeMcQuaid deleted the rubocop-remove-exceptions branch April 18, 2020 14:12
@lock lock bot added the outdated PR was locked due to age label May 20, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants