Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sh: fix custom shell prompt for zsh #7424

Merged
merged 1 commit into from Apr 23, 2020

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

The custom shell prompt for brew sh is only set for zsh if the -d flag is passed. (Note that this still won't overwrite a custom prompt set in dotfiles.) Also adds a missing % to make the prompt show the current working directory.

@MikeMcQuaid MikeMcQuaid merged commit 36a1c5c into Homebrew:master Apr 23, 2020
@EricFromCanada EricFromCanada deleted the shell-prompt-fix branch April 23, 2020 13:40
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 2, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants