Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shims/super/cc: relax restrictions with -Xclang #7429

Merged
merged 1 commit into from Apr 24, 2020
Merged

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Apr 23, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

For a lot of cases, -Xpreprocessor and -Xclang do similar things. We already have relaxed restrictions for -Xpreprocessor so we should give equal treatment to -Xclang.

Notably, the comment explicitly mentions -Xpreprocessor -fopenmp but -Xclang -fopenmp is equally valid and is used within CMake.

Fixes Homebrew/homebrew-core#53598 (comment). With this change, all the added args in that pull request can be removed again.

@Bo98 Bo98 merged commit 6b1d78b into Homebrew:master Apr 24, 2020
@Bo98 Bo98 deleted the xclang branch April 24, 2020 19:41
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 2, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants