shims/super/cc: relax restrictions with -Xclang #7429
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?For a lot of cases,
-Xpreprocessor
and-Xclang
do similar things. We already have relaxed restrictions for-Xpreprocessor
so we should give equal treatment to-Xclang
.Notably, the comment explicitly mentions
-Xpreprocessor -fopenmp
but-Xclang -fopenmp
is equally valid and is used within CMake.Fixes Homebrew/homebrew-core#53598 (comment). With this change, all the added
args
in that pull request can be removed again.