Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/mac/pkgconfig: add libffi.pc #7445

Merged
merged 1 commit into from Apr 27, 2020
Merged

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Apr 26, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@Bo98
Copy link
Member Author

Bo98 commented Apr 26, 2020

Should mean that some things that depended on brewed libffi can now depend on system libffi.

Though there's the question of whether it's worth it - we'd have to deal with a prehistoric version 2.1 on Mojave and earlier (where we likely need brewed libffi instead for some formulae) while having a modern 3.3-rc0 on Catalina (where the system library should be fine). Would be awkward to have this everywhere:

if MacOS.version < :catalina
  depends_on "libffi"
else
  uses_from_macos "libffi"
end

@MikeMcQuaid
Copy link
Member

Would be awkward to have this everywhere:

We could extend uses_from_macos to support before: and/or after: arguments. That was in the original PR, didn't work and so I removed it when fixing other issues.

@MikeMcQuaid MikeMcQuaid merged commit ba5d1ef into Homebrew:master Apr 27, 2020
@MikeMcQuaid
Copy link
Member

Thanks @Bo98!

@Bo98 Bo98 deleted the libffi-pc branch April 27, 2020 09:38
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Jan 2, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Jan 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants