Cask loader: add missing canonicalisation #7451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the JSON-based cask config loader was untested. This commit changes the interface to accept a string, making the loader easier to test. The commit also adds a test.
This commit adds a broken test, which is meant to expose a flaw in the constructor of `Cask::Config`. That (broken) test still passes because there’s also a flaw in our test helper code. The helper flaw happens to neutralize the `Cask::Config` flaw.
This commit fixes a flaw in the Cask test helper, causing the broken `Cask::Config` test to actually fail. The flaw occurred while patching the `Cask::Config::DEFAULT_DIRS` hash. While the original hash uses strings as values, the patched one used `Pathname` values, masking a broken `Cask::Config::from_json` test. Now the broken test fails like it should.
MikeMcQuaid
approved these changes
Apr 27, 2020
|
Thanks @claui! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew testswith your changes locally? A couple of tests fail on my local machine but all of them seem to be unrelated. See Fix cask loading after adding an artifact type #7417.This PR fixes a bug I missed in PR #7417.
Also, a flaw in our test helper masked the bug so it went past the radar.
This PR has four steps:
Change an interface for testability.
Add a test for the PR Fix cask loading after adding an artifact type #7417 bug.
That test is supposed to fail but actually passes due to a flaw in our test helper.
In other words: this commit reveals a test helper bug.
Fix the test helper bug. Now the test fails, exposing the PR Fix cask loading after adding an artifact type #7417 bug.
Fix the PR Fix cask loading after adding an artifact type #7417 bug.
For details to one of the steps, see the detailed commit message of the individual step.