Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formulary: install tap if needed. #7627

Merged
merged 1 commit into from May 22, 2020

Conversation

MikeMcQuaid
Copy link
Member

This matches what cask_loader does and is low risk given we no longer allow tap pinning.

Fixes #7626

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This matches what `cask_loader` does and is low risk given we no longer
allow tap pinning.

Fixes #7626
@MikeMcQuaid MikeMcQuaid merged commit 02733db into Homebrew:master May 22, 2020
@MikeMcQuaid MikeMcQuaid deleted the formulary_load_tap branch May 22, 2020 13:56
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 29, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing messages during install of formula that depends on a tap
2 participants