Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize Tapioca #7740

Merged
merged 3 commits into from
Jun 14, 2020
Merged

Initialize Tapioca #7740

merged 3 commits into from
Jun 14, 2020

Conversation

vidusheeamoli
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Tapioca is a library used to generate RBI (Ruby interface) files for use with Sorbet.

Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Would be good to put in the commit message what benefits this gem will give us in relation to Sorbet. The "203 errors => 29 errors" that you explained in Slack, for example.

@issyl0
Copy link
Member

issyl0 commented Jun 13, 2020

I'm going to assume that there's more to be added to this PR - like the RBI files that Tapioca generates for the gems - and not merge this tonight. 😇

@vidusheeamoli vidusheeamoli changed the title Gemfile: add tapioca Initialise Tapioca Jun 14, 2020
@vidusheeamoli vidusheeamoli changed the title Initialise Tapioca Initialize Tapioca Jun 14, 2020
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot of changes, but Tapioca fixes the vast majority of problems and means that we don't have to handcraft our own RBI files for gems (we just have to run bundle exec tapioca sync every so often), so that's good. (They also must be committed to the repo, before anyone asks that question.) Thanks, @vidusheeamoli!

@issyl0 issyl0 merged commit 0125c4c into Homebrew:master Jun 14, 2020
@issyl0 issyl0 added the gsoc-outreachy Google Summer of Code or Outreachy label Jun 14, 2020
@vidusheeamoli vidusheeamoli deleted the add-tapioca branch June 14, 2020 11:28
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 28, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gsoc-outreachy Google Summer of Code or Outreachy outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants