Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeCov YAML file. #7881

Merged
merged 1 commit into from Jul 2, 2020
Merged

Conversation

MikeMcQuaid
Copy link
Member

This should make the output and statuses a bit more friendly.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This should make the output and statuses a bit more friendly.
@MikeMcQuaid MikeMcQuaid merged commit ab20d1c into Homebrew:master Jul 2, 2020
@Bo98
Copy link
Member

Bo98 commented Jul 2, 2020

Is this in the right place?

the file must still be located in the root, dev/, or .github/ directories

@MikeMcQuaid
Copy link
Member Author

@Bo98 This is where it was before because it's the root from where the tests are run. I'm not sure how you verify if it's the right place now, to be honest. Any ideas/help would be welcome.

@MikeMcQuaid MikeMcQuaid deleted the codecov-yml branch July 3, 2020 07:53
@Bo98
Copy link
Member

Bo98 commented Jul 3, 2020

Well it seems to still be red when there is -0.01% changes and the links here: https://codecov.io/gh/Homebrew/brew/tree/master/cmd don't work.

@MikeMcQuaid
Copy link
Member Author

#7895

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 26, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants