Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet: set utils/user.rb to true #7946

Merged
merged 1 commit into from
Jul 11, 2020

Conversation

vidusheeamoli
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR moves utils/user.rb to true in sorbet/files.yaml and deals with the resulting type errors.

Library/Homebrew/utils/user.rb Show resolved Hide resolved
Library/Homebrew/utils/user.rb Show resolved Hide resolved
Copy link
Member

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@issyl0 issyl0 merged commit 2536f0a into Homebrew:master Jul 11, 2020
@vidusheeamoli vidusheeamoli deleted the utils-user-to-true branch July 12, 2020 19:45
@issyl0 issyl0 added the gsoc-outreachy Google Summer of Code or Outreachy label Jul 19, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 23, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gsoc-outreachy Google Summer of Code or Outreachy outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants