Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet: set os.rb to true #8019

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Conversation

vidusheeamoli
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR moves os.rb and os/linux.rb to true in sorbet/files.yaml and deals with the resulting type errors.

@issyl0
Copy link
Member

issyl0 commented Jul 17, 2020

This needs a rebase on the latest master, please. Then the license outdatedness check will go green (we hope). Otherwise, looks good! Good progress! ✨

- Set os/linux/glibc.rb and os/linux/kernel.rb to true in
  sorbet/files.yaml
@issyl0 issyl0 merged commit 531eb47 into Homebrew:master Jul 17, 2020
@vidusheeamoli vidusheeamoli deleted the set-os-to-true branch July 18, 2020 05:16
@issyl0 issyl0 added the gsoc-outreachy Google Summer of Code or Outreachy label Jul 19, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 23, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
gsoc-outreachy Google Summer of Code or Outreachy outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants