Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Cask::Auditor return a Hash with warnings and errors. #8115

Merged
merged 2 commits into from Jul 28, 2020
Merged

Make Cask::Auditor return a Hash with warnings and errors. #8115

merged 2 commits into from Jul 28, 2020

Conversation

reitermarkus
Copy link
Member

@reitermarkus reitermarkus commented Jul 28, 2020 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This should make it possible to print annotations in the brew cask ci command.

@reitermarkus reitermarkus mentioned this pull request Jul 28, 2020
Merged
MikeMcQuaid
MikeMcQuaid reviewed Jul 28, 2020
View reviewed changes
Library/Homebrew/test/dev-cmd/test_spec.rb
@@ -7,7 +7,7 @@
end

# randomly segfaults on Linux with portable-ruby.
describe "brew test", :integration_test, :needs_macos do
describe "brew test", :integration_test, :needs_macos, timeout: 120 do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely shouldn't be taking anywhere near the timeout? I wonder what's going on here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, I saw it spuriously fail yesterday.

@reitermarkus reitermarkus merged commit 698ac63 into Homebrew:master Jul 28, 2020
@reitermarkus reitermarkus deleted the cask-audit branch July 28, 2020 08:13
@reitermarkus reitermarkus mentioned this pull request Jul 28, 2020
Merged
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 22, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reitermarkus @MikeMcQuaid @BrewTestBot