Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uses: Print cask uses #8145

Merged
merged 3 commits into from Aug 3, 2020
Merged

uses: Print cask uses #8145

merged 3 commits into from Aug 3, 2020

Conversation

whoiswillma
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?
  • Move method for creating dependents into the DependenciesHelpers module so it can be used by brew deps and brew uses
  • Add cask dependents to list of dependents being searched

e.g. brew uses sshfs prints out the casks cellery macfusion macfusion-ng

MikeMcQuaid
MikeMcQuaid reviewed Jul 31, 2020
View reviewed changes
Library/Homebrew/dependencies.rb Outdated
@@ -122,4 +123,14 @@ def reject_ignores(dependables, ignores, includes)
includes.none? { |include| dep.send(include) }
end
end

def dependents(formulae_or_casks)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this get a basic unit test?

MikeMcQuaid
MikeMcQuaid reviewed Jul 31, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looking good so far!

@MikeMcQuaid
Copy link
Member

Thanks again @whoiswillma!

@MikeMcQuaid MikeMcQuaid merged commit a3efb35 into Homebrew:master Aug 3, 2020
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@whoiswillma @MikeMcQuaid @BrewTestBot