Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump-formula-pr: add bump- prefix to branch #8151

Merged
merged 1 commit into from Jul 31, 2020
Merged

bump-formula-pr: add bump- prefix to branch #8151

merged 1 commit into from Jul 31, 2020

Conversation

SeekingMeaning
Copy link
Contributor

@SeekingMeaning SeekingMeaning commented Jul 31, 2020 •
edited

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Alternative to #8046 (deleting branch after pushing to repository)

This results in bump branches being grouped together in the overall list outputted by git branch

cask-repair does something similar with the cask_repair_update prefix

@SeekingMeaning SeekingMeaning mentioned this pull request Jul 31, 2020
Closed
@dawidd6
Copy link
Member

dawidd6 commented Jul 31, 2020

Soo you mean prefix, not suffix then :)

@SeekingMeaning
Copy link
Contributor Author

Whoops

@SeekingMeaning SeekingMeaning changed the title bump-formula-pr: add bump- suffix to branch bump-formula-pr: add bump- prefix to branch Jul 31, 2020
MikeMcQuaid
MikeMcQuaid approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

dtrodrigues
dtrodrigues approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@dtrodrigues dtrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

@SeekingMeaning SeekingMeaning merged commit dbe8453 into Homebrew:master Jul 31, 2020
@SeekingMeaning SeekingMeaning deleted the bump-formula-pr/branch-name branch July 31, 2020 17:29
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@dtrodrigues dtrodrigues dtrodrigues approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SeekingMeaning @dawidd6 @MikeMcQuaid @dtrodrigues @BrewTestBot