Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caskroom: Add --caskroom to match --cellar #8203

Merged
merged 2 commits into from Aug 4, 2020
Merged

caskroom: Add --caskroom to match --cellar #8203

merged 2 commits into from Aug 4, 2020

Conversation

whoiswillma
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Add brew --caskroom to print the homebrew caskroom path.

Thoughts on merging this command with brew --cellar? brew --cellar atom would output the caskroom path of atom.

@MikeMcQuaid
Copy link
Member

--cellar) echo "$HOMEBREW_CELLAR"; exit 0 ;;
would be great to add.

Thoughts on merging this command with brew --cellar? brew --cellar atom would output the caskroom path of atom.

I think they should probably be kept separate because they are in different locations.

args = __caskroom_args.parse

if args.loaded_casks.blank?
puts Cask::Caskroom.path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is worth keeping but punting to Bash if possible, too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already implemented this, but why punt this to bash? Is it for speed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeh, it's dramatically faster.

@whoiswillma whoiswillma changed the title caskroom: Add --caskroom command to match --cellar caskroom: Add --caskroom to match --cellar Aug 3, 2020
@MikeMcQuaid MikeMcQuaid merged commit 9f80629 into Homebrew:master Aug 4, 2020
@MikeMcQuaid
Copy link
Member

Thanks again @whoiswillma!

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 21, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants