New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
workflows/tests: tweak step naming. #8212
Conversation
This should make it a bit more obvious what is being tested each time. The homebrew-core/linuxbrew-core style step actually runs the same command but, as far as I can tell, there's no way of altering the string that's output as the `name` based on the OS.
ac1f7c8
to
d8442d1
Compare
run: brew style --display-cop-names homebrew/core | ||
|
||
- name: Run brew style on official taps | ||
run: brew style --display-cop-names homebrew/bundle homebrew/services homebrew/test-bot | ||
|
||
- name: Run brew cask style | ||
- name: Run brew cask style on all taps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it actually run on all taps or just homebrew/cask
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to run on all taps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being able to run just on homebrew/cask
and with --display-cop-names
would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I meant is: Does it also run on all other official cask taps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like none of them are explicitly tapped before this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It runs on all official and unofficial cask taps and cask fixtures in Homebrew/brew. That's why we had to add a brew untap
above:
brew/.github/workflows/tests.yml
Lines 107 to 108 in 068568e
# don't care about `brew cask style` here. | |
brew untap adoptopenjdk/openjdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It runs on all official
But are all official ones tapped though on CI? Even homebrew/cask-fonts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I wouldn't don't think so.
This should make it a bit more obvious what is being tested each time.
The homebrew-core/linuxbrew-core style step actually runs the same command but, as far as I can tell, there's no way of altering the string that's output as the
name
based on the OS.brew style
with your changes locally?brew tests
with your changes locally?