Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows/tests: tweak step naming. #8212

Merged
merged 1 commit into from Aug 4, 2020

Conversation

MikeMcQuaid
Copy link
Member

This should make it a bit more obvious what is being tested each time.

The homebrew-core/linuxbrew-core style step actually runs the same command but, as far as I can tell, there's no way of altering the string that's output as the name based on the OS.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This should make it a bit more obvious what is being tested each time.

The homebrew-core/linuxbrew-core style step actually runs the same
command but, as far as I can tell, there's no way of altering the string
that's output as the `name` based on the OS.
@MikeMcQuaid MikeMcQuaid merged commit 875f9e3 into Homebrew:master Aug 4, 2020
@MikeMcQuaid MikeMcQuaid deleted the tests-tweak-naming branch August 4, 2020 15:32
run: brew style --display-cop-names homebrew/core

- name: Run brew style on official taps
run: brew style --display-cop-names homebrew/bundle homebrew/services homebrew/test-bot

- name: Run brew cask style
- name: Run brew cask style on all taps
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it actually run on all taps or just homebrew/cask?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to run on all taps.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Being able to run just on homebrew/cask and with --display-cop-names would be nice.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I meant is: Does it also run on all other official cask taps?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like none of them are explicitly tapped before this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs on all official and unofficial cask taps and cask fixtures in Homebrew/brew. That's why we had to add a brew untap above:

# don't care about `brew cask style` here.
brew untap adoptopenjdk/openjdk

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It runs on all official

But are all official ones tapped though on CI? Even homebrew/cask-fonts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I wouldn't don't think so.

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 20, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants