Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where the cask_opts env variable was not respected when running upgrade, reinstall, uninstall #8214

Merged
merged 3 commits into from Aug 5, 2020
Merged

Conversation

whoiswillma
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Process options using Cask::Cmd and pass the processed arguments to reinstall, uninstall, upgrade.

I'm pretty sure this fixes Homebrew/homebrew-cask#87045. I inspected the verbose/debug output and found that quarantine was not being propagated, although I'm not sure what that means. Is there a robust way to detect whether a cask has been quarantined, so that I might write a test for this?

@whoiswillma whoiswillma changed the title Fix issue where the cask_opts env variable was not respected when running upgrade, install, uninstall Fix issue where the cask_opts env variable was not respected when running upgrade, reinstall, uninstall Aug 4, 2020
@whoiswillma
Copy link
Member Author

I added methods in env_config.rb for other potential HOMEBREW_CASK_OPTS flags as well

@reitermarkus reitermarkus merged commit fb9b8f4 into Homebrew:master Aug 5, 2020
@reitermarkus
Copy link
Member

Thanks!

@MikeMcQuaid
Copy link
Member

Thanks for the help @reitermarkus and for the work @whoiswillma!

@whoiswillma
Copy link
Member Author

@reitermarkus I heard through Mike that you were working on improving the frontend for brew cask with CLI::Parser. What's left to do on that front, and what are the ways that I can help?

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 20, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew upgrade is not respecting HOMEBREW_CASK_OPTS="--no-quarantine"
4 participants