New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where the cask_opts env variable was not respected when running upgrade, reinstall, uninstall #8214
Merged
reitermarkus
merged 3 commits into
Homebrew:master
from
MLH-Fellowship:fix-cask-issue-87045
Aug 5, 2020
Merged
Fix issue where the cask_opts env variable was not respected when running upgrade, reinstall, uninstall #8214
reitermarkus
merged 3 commits into
Homebrew:master
from
MLH-Fellowship:fix-cask-issue-87045
Aug 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whoiswillma
changed the title
Fix issue where the cask_opts env variable was not respected when running upgrade, install, uninstall
Fix issue where the cask_opts env variable was not respected when running upgrade, reinstall, uninstall
Aug 4, 2020
reitermarkus
reviewed
Aug 4, 2020
6 tasks
I added methods in |
reitermarkus
reviewed
Aug 5, 2020
reitermarkus
reviewed
Aug 5, 2020
reitermarkus
reviewed
Aug 5, 2020
reitermarkus
approved these changes
Aug 5, 2020
Thanks! |
Thanks for the help @reitermarkus and for the work @whoiswillma! |
@reitermarkus I heard through Mike that you were working on improving the frontend for brew cask with |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?Process options using Cask::Cmd and pass the processed arguments to reinstall, uninstall, upgrade.
I'm pretty sure this fixes Homebrew/homebrew-cask#87045. I inspected the verbose/debug output and found that quarantine was not being propagated, although I'm not sure what that means. Is there a robust way to detect whether a cask has been quarantined, so that I might write a test for this?