Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask/cmd/upgrade: output cask upgrades on new line #8232

Merged
merged 1 commit into from Aug 6, 2020

Conversation

miccal
Copy link
Member

@miccal miccal commented Aug 6, 2020

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This changes the output of which casks are to be upgraded from a single line separated by , to each cask to be upgraded being printed on a new line; this is consistent with how formula upgrades are listed.

This should also (hopefully) help with things like this.

Thank you.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work again 👏🏻

@MikeMcQuaid MikeMcQuaid merged commit e514ec8 into Homebrew:master Aug 6, 2020
@miccal
Copy link
Member Author

miccal commented Aug 6, 2020

Thanks @MikeMcQuaid -- a simple change, but a useful one I hope.

@miccal miccal deleted the cask_upgrade branch August 6, 2020 10:49
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 20, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants